Skip to content

Commit

Permalink
Merge pull request #3569 from dougm/chores
Browse files Browse the repository at this point in the history
Various Docs and GitHub chores
  • Loading branch information
dougm authored Oct 4, 2024
2 parents 2faeee5 + 70edf99 commit 47b64c6
Show file tree
Hide file tree
Showing 16 changed files with 638 additions and 183 deletions.
31 changes: 4 additions & 27 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,38 +1,15 @@
## Description

Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Please include a summary of the change.

Closes: #(issue-number)

## Type of change

Please mark options that are relevant:

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to
not work as expected)
- [ ] This change requires a documentation update
- [ ] Build related change

## How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

- [ ] Test Description 1
- [ ] Test Description 2
Please describe any manual tests done to verify your changes.

## Checklist:
## Guidelines

- [ ] My code follows the `CONTRIBUTION` [guidelines] of this project
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have made corresponding changes to the documentation
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] New and existing unit tests pass locally with my changes
- [ ] Any dependent changes have been merged
Please read and follow the `CONTRIBUTION` [guidelines] of this project.

[guidelines]: https://github.com/vmware/govmomi/blob/main/CONTRIBUTING.md
6 changes: 3 additions & 3 deletions .github/workflows/govmomi-build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,17 +46,17 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.21
go-version: 1.22

- name: Restore Go cache
uses: actions/cache@v4
with:
path: |
~/.cache/go-build
~/go/pkg/mod
key: ${{ runner.os }}-go-1.21-${{ hashFiles('**/go.sum') }}
key: ${{ runner.os }}-go-1.22-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-1.21-
${{ runner.os }}-go-1.22-
- name: Create CHANGELOG
env:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/govmomi-go-lint.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.21
go-version: 1.22
id: go

- name: Go Lint
Expand All @@ -61,7 +61,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: 1.21
go-version: 1.22
id: go

- name: Install Tools
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/govmomi-go-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
name: Run Unit Tests
strategy:
matrix:
go-version: ["1.21", "1.22"]
go-version: ["1.22", "1.23"]
platform: ["ubuntu-20.04"]
fail-fast: false

Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/govmomi-govc-tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
strategy:
fail-fast: false
matrix:
go-version: ["1.21"]
go-version: ["1.22"]
platform: ["ubuntu-20.04"]
cmd: ["govc-test"]
experimental: [false]
Expand Down Expand Up @@ -73,7 +73,7 @@ jobs:
name: Verify govc docs are up2date
strategy:
matrix:
go-version: ["1.21"]
go-version: ["1.22"]
platform: ["ubuntu-20.04"]
runs-on: ${{ matrix.platform }}
timeout-minutes: 3
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/govmomi-release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ on:
type: string
default: 'v0.99.0'
dryrun:
description: 'Verify release workflow without pushing any changes (catches most but not all errors)'
description: 'Dry Run (verify workflow without pushing a release)'
type: boolean
required: false
default: true
Expand Down Expand Up @@ -72,7 +72,7 @@ jobs:
- name: Set up Go
uses: actions/setup-go@v5
with:
go-version: '1.22'
go-version: '1.23'

- name: Update version.go
run: |
Expand Down Expand Up @@ -102,9 +102,9 @@ jobs:
# check whether the new tag is also the latest
if [[ $LATEST == $TAG ]]; then
echo "islatest::true >> $GITHUB_OUTPUT"
echo "islatest=true >> $GITHUB_OUTPUT"
else
echo "islatest::false >> $GITHUB_OUTPUT"
echo "islatest=false >> $GITHUB_OUTPUT"
fi
- name: Push changes and tag to release branch
Expand Down
6 changes: 6 additions & 0 deletions .mailmap
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,9 @@ Yun Zhou <[email protected]> <[email protected]>
Zach G <[email protected]> zach96guan <[email protected]>
Zach Tucker <[email protected]> <[email protected]>
Zee Yang <[email protected]> <[email protected]>
Arunesh Pandey <[email protected]> Arunesh Pandey <[email protected]>
Eric Cao <[email protected]> Eric Cao <[email protected]>
Eric Cao <[email protected]> Eric Cao <[email protected]>
Ryan Johnson <[email protected]> Ryan Johnson <[email protected]>
Stoyan Zhelyazkov <[email protected]> Stoyan Zhelyazkov <[email protected]>
Yanlei Zhao <[email protected]> Yanlei Zhao <[email protected]>
Loading

0 comments on commit 47b64c6

Please sign in to comment.