Merge pull request #3177 from hickeng/topic/hickeng/container-backed-…

…sim-hosts

This adds support for backing a host with a container in a similar
manner to how we back VMs with containers.

This functions as is but is not particularly useful without planned
follow on work to provide a container image with mocks for ESXi
cli commands and presentation of vcsim as a hostd endpoint.

.github/workflows/govmomi-go-tests.yaml

@@ -60,3 +60,6 @@ jobs:
           TEST_TIMEOUT: 5m
           TEST_OPTS: ""
         run: make go-test
+      - name: Debug with tmate on failure
+        if: ${{ failure() }}
+        uses: mxschmitt/action-tmate@v3

.github/workflows/govmomi-govc-tests.yaml

@@ -65,6 +65,10 @@ jobs:
         run: |
           make ${{ matrix.cmd }}
 
+      - name: Debug with tmate on failure
+        if: ${{ failure() }}
+        uses: mxschmitt/action-tmate@v3
+
   govc-docs:
     name: Verify govc docs are up2date
     strategy:

Makefile

@@ -136,7 +136,7 @@ endif
 
 .PHONY: go-test
 go-test: ## Runs go unit tests with race detector enabled
-	GORACE=$(GORACE) $(GO) test \
+	GORACE=$(GORACE) CGO_ENABLED=1 $(GO) test \
   -count $(TEST_COUNT) \
   -race \
   -timeout $(TEST_TIMEOUT) \

govc/test/vcsim.bats

@@ -340,7 +340,7 @@ EOF
   run docker inspect -f '{{.State.Status}}' "$name"
   assert_success "running"
 
-  run docker volume inspect "$name"
+  run docker volume inspect "$name--dmi"
   assert_success
 
   run govc vm.destroy $vm

simulator/cluster_compute_resource.go

@@ -66,7 +66,7 @@ func (add *addHost) Run(task *Task) (types.AnyType, types.BaseMethodFault) {
 	}
 
 	host := NewHostSystem(template)
-	host.configure(spec, add.req.AsConnected)
+	host.configure(task.ctx, spec, add.req.AsConnected)
 
 	task.ctx.Map.PutEntity(cr, task.ctx.Map.NewEntity(host))
 	host.Summary.Host = &host.Self