govc: Add device protocol configuration for vm.network.add

[lubronzhan]

Description

When user add network adapter type vmxnet3vrdma, they can configure the protocol rocev2/rocev1. This is only supported on adapter type vmxnet3vrdma.

Closes: ##3167

Type of change

Please mark options that are relevant:

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to
  not work as expected)
• This change requires a documentation update
• Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

• Test Description 1
  Built on a linux machine. Example output

Correct help message

kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add  --help
Usage: ./govc vm.network.add [OPTIONS]

Add network adapter to VM.
...
  -net.address=                   Network hardware address
  -net.protocol=                  Network device protocol. Applicable to vmxnet3vrdma. Default to 'rocev2'

Attempt to add adapter with protocol

## ensure no regression
kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter vmxnet3vrdma
kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter e1000e
kubo@keDgLYFEehvWP:~/govmomi/govc$

## valid input

kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter vmxnet3vrdma -net.protocol rocev2
kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter vmxnet3vrdma -net.protocol rocev1

## invalid protocol
kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter vmxnet3vrdma -net.protocol rocev0
./govc: invalid device protocol 'rocev0'

## invalid protocol&adapter combination
kubo@keDgLYFEehvWP:~/govmomi/govc$ ./govc vm.network.add -vm test -net "port-group-vlan-101" -net.adapter e1000e -net.protocol rocev1
./govc: device protocol is only suppported for vmxnet3vrdma at the moment

• Test Description 2

Checklist:

• My code follows the CONTRIBUTION
  guidelines of
  this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• Any dependent changes have been merged

[lubronzhan]

just noticed I didn't follow the issue-<> branch name

[dougm]

Thanks @lubronzhan
Just requesting a typo fix. But also cannot merge currently, unrelated to your change, but CI (goreleaser) needs fixing. They removed some deprecated options we're using: https://goreleaser.com/deprecations/#archivesreplacements
I've not done any goreleaser related work myself, other than bumping the go version once, but will try to look at that soon.

[dougm]

typo: supported

[lubronzhan]

Thanks Doug.

[lubronzhan]

I fixed the release here #3170
It looks straightforward from the doc. Hopefully I didn't do it wrong

[dougm]

just noticed I didn't follow the issue-<> branch name

Branch name doesn't matter, but in the commit you have:

Closes: 3167
Missing the # needed by GH to auto-close and changelog generator:
Closes: #3167

Mentioning that since you'll need to rebase with your goreleaser change to merge anyhow (thanks again for that)

[lubronzhan]

Ok let me try that thanks

[dougm]

Thanks again @lubronzhan