Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opentelemetry collector contrib as Notable User in README #3172

Merged
merged 2 commits into from
Jul 17, 2023

Conversation

schmikei
Copy link
Contributor

@schmikei schmikei commented Jul 5, 2023

Description

We've been using govmomi to great success for quite a while for the vcenterreceiver component of opentelemetry's contrib distribution. Was hoping to that we could be listed as another success story in the notable users of the great library that has been built here https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/vcenterreceiver 🚀

If there is a process for this let me know, but figured I'd just shout out the great work and usefulness of this library 😄

Closes: didn't think an issue was necessary but happy to create one :)

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Feel free to see change here: https://github.com/schmikei/govmomi/tree/notable-user-otel-contrib

Checklist:

  • My code follows the CONTRIBUTION
    guidelines of
    this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@schmikei, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@vmwclabot
Copy link
Member

@schmikei, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@vmwclabot
Copy link
Member

@schmikei, VMware has approved your signed contributor license agreement.

Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @schmikei , great to hear your success story!

@dougm dougm merged commit 0602b60 into vmware:main Jul 17, 2023
10 checks passed
@schmikei schmikei deleted the notable-user-otel-contrib branch July 17, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants