-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check the error chain when validating if it's x509 error #3175
Conversation
cc @dougm (context: this issue currently blocks adoption of Go 1.20 in CAPV) |
I think Doug is on PTO this week, he should be able to review this next week |
Perfect! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lubronzhan
The commit message is used to generate change log, auto-close issues, etc., can you please update? Currently is:
issue-3174: check the error chain when validating if it's
x509 error
Should include fix:
prefix and Closes: #NNNN
:
fix: check the error chain when validating x509 error
Closes: #3174
2bd147a
to
04f8594
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lubronzhan
We can merge when CI passes (snapshot release failed, sometimes will timeout)
@dougm Newbie question (entirely new to CAPV / govmomi). How quickly could we get a release which includes this fix? :) |
I cherry-picked the change to the I haven't looked close yet, but goreleaser has been removing deprecated stuff recently. So there's no govc release binary yet, but the new v0.30.6 tag is there that CAPV can use: https://github.com/vmware/govmomi/tree/v0.30.6 |
Perfect. Thank you very much!! |
Description
Please include a summary of the change and which issue is fixed. Please also
include relevant motivation and context. List any dependencies that are required
for this change.
Check the error chain when checking if error is x509 related. This should be compatible with both golang 1.20 and 1.19
Closes: ##3174
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.
Compiles CPI with 1.20 and configures CPI with tlsthumbprint, and the error doesn't appear.
Checklist:
CONTRIBUTION
guidelines of
this project