-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add VAPI bindings for guest namespaces and virtual machine classes #3397
Conversation
31f2c27
to
0351154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stoyanzhelyazkov , looks good overall. Mainly changing the handful of commands to use ARG instead of -flag would be good to make in this PR before merging.
aeb64c5
to
e46123f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stoyanzhelyazkov !
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
1434c16
to
8a618f7
Compare
Description
We already have bindings for supervisor enable/disable.
I am building on top of those to add support for guest namespace and virtual machine class CRUD operations.
I have taken into account the fact that the original supervisor bindings were implemented when vSphere 7.0.3 was the latest version in existence and I have made sure that these new bindings do not use anything that was added to the API after 7.0.3.
For reference:
https://developer.vmware.com/apis/vsphere-automation/v7.0U3/vcenter/api/vcenter/namespaces/instances/
https://developer.vmware.com/apis/vsphere-automation/v7.0U3/vcenter/namespace_management/
Type of change
Please mark options that are relevant:
not work as expected)
How Has This Been Tested?
I ran the "lint-fix" and "test" make scripts
I also added new cases to "namespace.bats"
And of course I implemented & tested the whole thing with a live vCenter. These changes work with 7.0.3 and with 8.0.X
Checklist:
CONTRIBUTION
guidelines of this project