Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VAPI bindings for guest namespaces and virtual machine classes #3397

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

spacegospod
Copy link
Contributor

Description

We already have bindings for supervisor enable/disable.
I am building on top of those to add support for guest namespace and virtual machine class CRUD operations.

I have taken into account the fact that the original supervisor bindings were implemented when vSphere 7.0.3 was the latest version in existence and I have made sure that these new bindings do not use anything that was added to the API after 7.0.3.

For reference:
https://developer.vmware.com/apis/vsphere-automation/v7.0U3/vcenter/api/vcenter/namespaces/instances/
https://developer.vmware.com/apis/vsphere-automation/v7.0U3/vcenter/namespace_management/

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

I ran the "lint-fix" and "test" make scripts
I also added new cases to "namespace.bats"
And of course I implemented & tested the whole thing with a live vCenter. These changes work with 7.0.3 and with 8.0.X

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/namespace/create.go Show resolved Hide resolved
@spacegospod spacegospod force-pushed the feature/namespaces branch 4 times, most recently from 31f2c27 to 0351154 Compare April 8, 2024 10:42
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/USAGE.md Outdated Show resolved Hide resolved
govc/test/namespace.bats Show resolved Hide resolved
govc/test/namespace.bats Show resolved Hide resolved
govc/test/namespace.bats Outdated Show resolved Hide resolved
govc/test/namespace.bats Outdated Show resolved Hide resolved
vapi/namespace/internal/internal.go Show resolved Hide resolved
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stoyanzhelyazkov , looks good overall. Mainly changing the handful of commands to use ARG instead of -flag would be good to make in this PR before merging.

govc/USAGE.md Outdated Show resolved Hide resolved
govc/namespace/vmclass/change.go Outdated Show resolved Hide resolved
govc/namespace/vmclass/create.go Outdated Show resolved Hide resolved
vapi/namespace/simulator/simulator.go Outdated Show resolved Hide resolved
vapi/namespace/simulator/simulator.go Outdated Show resolved Hide resolved
@spacegospod spacegospod force-pushed the feature/namespaces branch 2 times, most recently from aeb64c5 to e46123f Compare April 9, 2024 11:40
govc/USAGE.md Outdated Show resolved Hide resolved
govc/namespace/ls.go Outdated Show resolved Hide resolved
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stoyanzhelyazkov !

@spacegospod spacegospod merged commit 1caad5c into vmware:main Apr 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants