Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): enable rpm builds and add archs #3403

Merged
merged 1 commit into from
Apr 11, 2024
Merged

build(deps): enable rpm builds and add archs #3403

merged 1 commit into from
Apr 11, 2024

Conversation

smitterl
Copy link
Contributor

@smitterl smitterl commented Apr 9, 2024 •
edited
Loading

Description

Enable rpm package build for several archs.

Closes: #3404

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide
instructions so we can reproduce. If applicable, please also list any relevant
details for your test configuration.

  • Execute goreleaser goreleaser release --clean --snapshot --rm-dist --verbose --skip docker,homebrew; install rpm on x86_64; call govc --help

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@vmwclabot
Copy link
Member

@smitterl, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@smitterl smitterl marked this pull request as draft April 9, 2024 08:52
@smitterl smitterl mentioned this pull request Apr 9, 2024
Merged
@vmwclabot
Copy link
Member

@smitterl, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@smitterl smitterl marked this pull request as ready for review April 9, 2024 10:49
@smitterl smitterl changed the title Enable rpm builds and add archs build(deps): enable rpm builds and add archs Apr 9, 2024
dougm
dougm reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smitterl , we should be able to merge this before next release.

.goreleaser.yml Outdated
@@ -13,6 +14,8 @@ builds:
- arm
- arm64
- mips64le
- 386
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We had removed 386 a while back. In part because of bug reports where the problem was folks downloading 386-linux and trying to run on x64 w/o 32-bit toolchain. Are distros still supporting 32-bit installs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougm I installed it on RHEL and Fedora on x86_64 and ran govc --help without any issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to find out if there's an alternative goarch like 'intel64' but without access.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougm Gosh, I just learned that amd64 are the ones for 'x86_64'. My intention was not to add 32-bit. So, I just updated it to only add s390x, not 386.

@smitterl
build(deps): enable rpm builds and add archs
e66065a 
1. Add nfpm configuration for rpm builds.
2. Add x86_64 and s390x architectures.
3. Skip main.go check as there are several.
4. Rename deprecated `folder` to `directory`.

Tested with
```
goreleaser release --clean --snapshot --rm-dist --verbose --skip docker,homebrew
```

Closes: vmware#3404

Signed-off-by: Sebastian Mitterle <[email protected]>
@vmwclabot
Copy link
Member

@smitterl, VMware has approved your signed contributor license agreement.

dougm
dougm approved these changes Apr 11, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @smitterl

@dougm dougm merged commit 949320c into vmware:main Apr 11, 2024
10 checks passed
@smitterl smitterl deleted the add_rpm_build branch April 12, 2024 13:07
@smitterl smitterl mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable RPM package builds
3 participants
@smitterl @vmwclabot @dougm