-
Notifications
You must be signed in to change notification settings - Fork 911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
api: change RetrieveProperties to collect results in batches #3408
Conversation
f75833d
to
dc157ad
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I opened dougm#2 against this PR to pull in some tests. I will also be honest, one thing has me worried, the documentation around
Specifically the last line -- |
'RetrieveProperties' is deprecated since 4.1 Use RetrievePropertiesEx + ContinueRetrievePropertiesEx to collect in batches.
This patch adds support to vC Sim for RetrievePropertiesEx and ContinueRetrievePropertiesEx and their paged results semantics.
d3e2858
to
f5080d3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks @dougm !
'RetrieveProperties' is deprecated since 4.1
Use RetrievePropertiesEx + ContinueRetrievePropertiesEx to collect in batches.