govc: add default output formatting for namespace commands #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including a few other minor changes for the new set of namespace commands.
dougm
commented
Apr 12, 2024
| @@ -281,7 +281,6 @@ func (h *Handler) namespaces(w http.ResponseWriter, r *http.Request) { | |||
| if len(subpath) > 0 { | |||
| if entry, contains := namespacesMap[subpath]; contains { | |||
| var spec namespace.NamespacesInstanceUpdateSpec | |||
| // If vapi.Decode fails it sets the status to bad request | |||
There was a problem hiding this comment.
note: removed these comments since it's included in the function doc (and we use vapi.Decode this way all over)
spacegospod
approved these changes
Apr 12, 2024
spacegospod
reviewed
Apr 12, 2024
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| cmd.JSON = !cmd.All() |
There was a problem hiding this comment.
Just FYI - I did the same thing on another PR over a month ago #3368
I'm saying this in case you're working on eliminating the "only-JSON-output-supported" pattern :)
There was a problem hiding this comment.
I remember, but I've yet to use vLCM (directly at least). I use vSphere Namespaces everyday and am happy to replace stuff like below with the new govc commands, thanks!
# now govc namespace.create
govc session.login -r -X POST /api/vcenter/namespaces/instances \
<<<'{"cluster": "domain-c9","namespace": "velero"}'
# now govc namespace.ls
govc session.login -r -X GET /api/vcenter/namespaces/instances | jq -r .[].namespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including a few other minor changes for the new set of namespace commands.