Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: add SSLCertificate to TransferEndpoint in content library API #3421

Merged
merged 1 commit into from
Apr 22, 2024
Merged

api: add SSLCertificate to TransferEndpoint in content library API #3421

merged 1 commit into from
Apr 22, 2024

Conversation

ericvmw
Copy link
Contributor

@ericvmw ericvmw commented Apr 22, 2024

Description

Add the optional SSLCertificate field to TransferEndpoint in content library API so it can be specified to probe remote transfer endpoint or upload file from remote endpoint by pull. The field is already in the ProbeResult as an optional field.

Closes: #3420

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

@ericvmw
api: add SSLCertificate to TransferEndpoint in content library API
f2852e3 
Add the optional SSLCertificate field to TransferEndpoint in content
library API so it can be specified to probe remote transfer endpoint or
upload file from remote endpoint by pull. The field is already in the
ProbeResult as an optional field.

Closes: vmware#3420
@ericvmw ericvmw requested a review from dougm April 22, 2024 19:35
dougm
dougm approved these changes Apr 22, 2024
View reviewed changes
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericvmw ericvmw merged commit 2b9c9ca into vmware:main Apr 22, 2024
11 checks passed
@ericvmw ericvmw self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dougm dougm dougm approved these changes

Assignees

@ericvmw ericvmw

Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] add optional SSLCertificate to TransferEndpoint in content library API
3 participants
@ericvmw @dougm @vmwclabot