Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: Update ConfigInfoToConfigSpec #3434

Merged
merged 1 commit into from
May 7, 2024

Conversation

akutz
Copy link
Member

@akutz akutz commented May 7, 2024

Description

This patch updates the ConfigInfoToConfigSpec helper based on new API fields.

Closes: NA

Type of change

Please mark options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Build related change

How Has This Been Tested?

  • Ran the unit test for the function

Checklist:

  • My code follows the CONTRIBUTION guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

This patch updates the ConfigInfoToConfigSpec helper
based on new API fields.
Copy link
Member

@dougm dougm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @akutz , lgtm

@akutz akutz merged commit 3a7ad6a into vmware:main May 7, 2024
11 checks passed
@akutz akutz deleted the feature/update-configinfo-to-configspec branch May 7, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants