fix: update controller's device list in AssignController

[dilyar85]

Description

This PR updates the AssignController function to add the assigned device to the controller's device list. This ensures that PickController() function returns the appropriate controller with available slots, as it's based on the current number of devices attached to the controller.

Closes: N/A

How Has This Been Tested?

• Updated the existing TestAssignController to validate the controller's device list.
• Deployed a VM with multiple devices, invoking AssignController during a single VM reconfiguration task. Verified that the devices were properly assigned to the controller without exceeding the maximum allowed slots:

$ govc device.ls -vm vm-iso-3-cdroms cdrom-\*
cdrom-3002  VirtualCdrom  ISO [sharedVmfs-0] contentlib-...
cdrom-3000  VirtualCdrom  ISO [sharedVmfs-0] contentlib-...
cdrom-3001  VirtualCdrom  ISO [sharedVmfs-0] contentlib-...

$ govc device.info -json -vm vm-iso-3-cdroms ide-\* | jq '.devices[] | {name, device}'
{
  "name": "ide-200",
  "device": [
    3000,
    3001
  ]
}
{
  "name": "ide-201",
  "device": [
    3002
  ]
}

Guidelines

Please read and follow the CONTRIBUTION guidelines of this project.

[dougm]

Thanks @dilyar85 !

[dougm]

Let's fix this failing test first: https://github.com/vmware/govmomi/actions/runs/11264744416/job/31326263686?pr=3588
I can take a closer look in a bit

[dougm]

vcsim may change the Device.Key, in which case we need to change the Controller.Device reference too:

diff --git a/simulator/virtual_machine.go b/simulator/virtual_machine.go
index a596798d..1bda935c 100644
--- a/simulator/virtual_machine.go
+++ b/simulator/virtual_machine.go
@@ -1279,6 +1279,7 @@ func (vm *VirtualMachine) configureDevice(
 	d := device.GetVirtualDevice()
 	var controller types.BaseVirtualController
 
+	key := d.Key
 	if d.Key <= 0 {
 		// Keys can't be negative; Key 0 is reserved
 		d.Key = devices.NewKey()
@@ -1293,6 +1294,19 @@ func (vm *VirtualMachine) configureDevice(
 		d.Key++
 	}
 
+	// Update device controller's key reference
+	if key != d.Key {
+		if p := devices.FindByKey(d.ControllerKey); p != nil {
+			c := p.(types.BaseVirtualController).GetVirtualController()
+			for i := range c.Device {
+				if c.Device[i] == key {
+					c.Device[i] = d.Key
+					break
+				}
+			}
+		}
+	}
+
 	label := devices.Name(device)
 	summary := label
 	dc := ctx.Map.getEntityDatacenter(ctx.Map.Get(*vm.Parent).(mo.Entity))

[dilyar85]

Thanks @dougm! Updated with your suggestion above and got all the tests passed.

[dougm]

Thanks @dilyar85 !