proof of concept for how to replace audit.AuditEventFrom
#2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pinniped-dev canceled.
|
cfryanr
commented
Sep 25, 2025
| sigs.k8s.io/yaml v1.6.0 | ||
| ) | ||
|
|
||
| replace k8s.io/apiserver => ../kubernetes-fork/staging/src/k8s.io/apiserver |
There was a problem hiding this comment.
Obviously, this replace statement is only for proof of concept. I had cloned kubernetes/kubernetes#133765 locally at this location.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a proof of concept for how to replace
audit.AuditEventFromusing changes from kubernetes/kubernetes#133765.Kubernetes 1.34 libraries removed this public function, and kubernetes/kubernetes#133765 is a PR to bring back similar functionality as a new public function so we can make use of it.
This PR mainly shows how to update the impersonator unit tests. I did not try to make necessary updates to other code related to bumping to Kubernetes 1.34 libraries in this PR, so I do not expect this PR to build or pass tests.
Release note: