Allow Query String Parameters in the URL #469
Conversation
| @@ -836,6 +838,19 @@ TDNFJoinPath(char **ppszPath, ...) | |||
| * before stripping all leading slashes */ | |||
| if (i == 0) | |||
| { | |||
| /* we also check to see if the base path is a remote URL; for URLs | |||
There was a problem hiding this comment.
I don't really like that you are using TDNFJoinPath() for this, which is a generic function to join path elements (much like python's os.path.join(). I think it's not very efficient, because this code will now be used in all places where we join paths, which are mostly local.
Instead, I think we should create another version of this function that is only used where we need this functionality of preserving the URL query string.
There was a problem hiding this comment.
@adithyaj , are you going to address my comments?
|
Is this still an issue? @adithyaj , will you address my review comments? Otherwise, I will close this. |
|
Closing this, looks like the issue is stalled. Feel free to reopen, or create another PR with my comments addressed. |
As discussed in #467, when the baseURL has appended query string parameters, tdnf does not recognize this as a query string parameter and treats this as a standard baseURL and appends paths like the
repomd.xmlto the end of this. For query strings, the expectation is that these parameters would appear at the very end of the URL, after the paths have been appended.The following is a change to the
common/utils.cpath to update the URL in the event we see a query string.