Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change && to || for TDNFAlterRepoState for invalid argument check #499

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

sameluch
Copy link
Contributor

During development of virtual snapshot functionality, I noticed this as a bug in client/repolist.c. If pszId is NULL, but pRepos is not NULL, no 1602 error will be given to the user.

If this is intentional, this PR can be closed.

@vmwclabot
Copy link
Member

@sameluch, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

@oliverkurth
Copy link
Contributor

oliverkurth commented Sep 24, 2024

Thanks you @sameluch! Can you please sign the license agreement? Then I can merge this.

You can also rebase to fix the workflow error.

@vmwclabot
Copy link
Member

@sameluch, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

@sameluch sameluch force-pushed the Fix-Invalid-Argument-repolist branch from 2a83dc7 to b648153 Compare October 7, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants