Bump up golang in github actions

And fix resuting linter errors

Signed-off-by: Anna Khmelnitsky <[email protected]>

.github/workflows/golangci-lint.yml

@@ -5,10 +5,10 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/setup-go@v3
+      - uses: actions/checkout@v4
+      - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
-      - uses: actions/checkout@v3
+          go-version-file: 'go.mod'
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:

.github/workflows/golangci-ut.yml

@@ -5,10 +5,10 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
+      - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
-          go-version: 1.22
-      - uses: actions/checkout@v4
+          go-version-file: 'go.mod'
       - name: Install dependencies
         run: |
           go get .

.github/workflows/release.yml

@@ -14,20 +14,22 @@ jobs:
     steps:
       -
         name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
         with:
           fetch-depth: 0
       -
         name: Set up Go
         uses: actions/setup-go@v3
         with:
-          go-version: 1.19
+          go-version-file: 'go.mod'
       -
         name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
           version: v1.50
           args: --issues-exit-code=1
+          skip-pkg-cache: true
+          skip-build-cache: true
       -
         name: Import GPG key
         id: import_gpg

.golangci.yml

@@ -21,7 +21,6 @@ linters:
     - gosec
     - goimports
     - vet
-    - revive
     - misspell
     - gosimple
     - staticcheck

nsxt/data_source_nsxt_policy_uplink_host_switch_profile.go

@@ -5,6 +5,7 @@ package nsxt
 
 import (
 	"fmt"
+
 	"github.com/vmware/vsphere-automation-sdk-go/runtime/bindings"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

nsxt/data_source_nsxt_upgrade_prepare_ready.go

@@ -5,6 +5,7 @@ package nsxt
 
 import (
 	"fmt"
+
 	"github.com/vmware/terraform-provider-nsxt/nsxt/util"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"

nsxt/resource_nsxt_upgrade_run.go

@@ -393,6 +393,7 @@ func prepareUpgrade(upgradeClientSet *upgradeClientSet, d *schema.ResourceData,
 			continue
 		}
 
+		//#nosec G601 Ignore implicit memory aliasing in for loop temporarily
 		status, err := getUpgradeStatus(upgradeClientSet.StatusClient, &component)
 		if err != nil {
 			return err
@@ -407,13 +408,15 @@ func prepareUpgrade(upgradeClientSet *upgradeClientSet, d *schema.ResourceData,
 		if status.Status == model.ComponentUpgradeStatus_STATUS_IN_PROGRESS {
 			upgradeClientSet.PlanClient.Pause()
 		}
+		//#nosec G601 Ignore implicit memory aliasing in for loop temporarily
 		err = waitUpgradeForStatus(upgradeClientSet, &component, inFlightComponentUpgradeStatus, staticComponentUpgradeStatus)
 		if err != nil {
 			return err
 		}
 
 		// Cache the group list before reset as group IDs change by reset operation. References for some types of groups
 		// could be affected here
+		//#nosec G601 Ignore implicit memory aliasing in for loop temporarily
 		preResetGroupList, err := upgradeClientSet.GroupClient.List(&component, nil, nil, nil, nil, nil, nil, nil)
 		if err != nil {
 			return err
@@ -746,7 +749,9 @@ func runUpgrade(upgradeClientSet *upgradeClientSet, partialUpgradeMap map[string
 			prevComponent = component
 			completeLog = fmt.Sprintf("[INFO] %s upgrade is partially completed.", component)
 		}
+		//#nosec G601 Ignore implicit memory aliasing in for loop temporarily
 		upgradeClientSet.PlanClient.Upgrade(&component)
+		//#nosec G601 Ignore implicit memory aliasing in for loop temporarily
 		err = waitUpgradeForStatus(upgradeClientSet, &component, pendingStatus, targetStatus)
 		if err != nil {
 			return err