Add default_security_profile attribute to project #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksamoray
force-pushed
the
project-default-sec-profile
branch
from
e8ec6c5
to
07deb6d
Compare
|
/test-all |
annakhm
reviewed
Sep 19, 2024
nsxt/resource_nsxt_policy_project.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| return patchVpcSecurityProfile(d, connector, id) |
There was a problem hiding this comment.
I suggest to wrap this in HasChange ("default_security_profile") to avoid unnecessary call
annakhm
reviewed
Sep 19, 2024
nsxt/resource_nsxt_policy_project.go
Outdated
| _, err := client.Get(defaultOrgID, projectID, "default") | ||
|
|
||
| if isNotFoundError(err) && !enabled { | ||
| // No action required |
There was a problem hiding this comment.
Are we dealing with the case in which default profile was not created yet? In this case, should we busy wait here?
ksamoray
force-pushed
the
project-default-sec-profile
branch
from
07deb6d
to
8cf49ee
Compare
|
/test-all |
Add the attribute above and manage it vs the VpcSecurityProfiles client Signed-off-by: Kobi Samoray <[email protected]>
ksamoray
force-pushed
the
project-default-sec-profile
branch
from
8cf49ee
to
aea3f25
Compare
|
/test-all |
annakhm
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the attribute above and manage it vs the VpcSecurityProfiles client