Connection data sources #1387
Merged
Connection data sources #1387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @annakhm I think there are some DS here which exist in master but not in vpc20-feature-branch, which break the linter (and probably compilation as well). |
annakhm
force-pushed
the
conn-data-sources
branch
from
76cc052
to
87a223d
Compare
Forgot to add the files to PR :) |
ksamoray
approved these changes
Oct 2, 2024
salv-orlando
reviewed
Oct 2, 2024
In addition, make tier0_path attributed required in gateway connection resource, as NSX requires it Signed-off-by: Anna Khmelnitsky <[email protected]>
annakhm
force-pushed
the
conn-data-sources
branch
from
87a223d
to
673cb50
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, make tier0_path attributed required in gateway connection resource, as NSX requires it
Signed-off-by: Anna Khmelnitsky [email protected]