Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error use of multitenancy with T0 gateways #917

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

ksamoray
Copy link
Collaborator

@ksamoray ksamoray commented Jul 9, 2023

T0 gateways do not have multitenancy support

@ksamoray ksamoray changed the title Error use of gateway DNS forwarder with T0 Error use of multitenancy with T0 gateways Jul 9, 2023
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jul 9, 2023

/test-all

1 similar comment
@ksamoray
Copy link
Collaborator Author

ksamoray commented Jul 9, 2023

/test-all

@annakhm
Copy link
Collaborator

annakhm commented Jul 10, 2023

LGTM but I would suggest to move the message string out to avoid duplication, and change multitenancy to context to be more precise

@ksamoray
Copy link
Collaborator Author

LGTM but I would suggest to move the message string out to avoid duplication, and change multitenancy to context to be more precise

Makes sense, I'll revise it.

T0 gateways do not have multitenancy support

Signed-off-by: Kobi Samoray <[email protected]>
@ksamoray ksamoray merged commit e9d63f8 into vmware:master Jul 12, 2023
2 checks passed
@ksamoray ksamoray deleted the gw_dns_fw_bug branch July 12, 2023 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants