feat: accept entity names as inputs for several resources #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
…es easier Signed-off-by: Stoyan Zhelyazkov <[email protected]>
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
github-actions
bot
added
documentation
Signed-off-by: Stoyan Zhelyazkov <[email protected]>
spacegospod
force-pushed
the
feature/name-vs-id
branch
from
7b27d8c
to
8da010e
Compare
tenthirtyam
approved these changes
Jun 28, 2024
tenthirtyam
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
Accepting entity identifiers as inputs is convenient when these entities are managed by Terraform but not so much when they are created externally.
I'm modifying the resource schemas for hosts, clusters and edge clusters so that they accept network pool names, domain names and compute cluster names respectively in addition to their IDs.
Setting values for both attributes at the same time is not allowed and will result in an explicit error.
Type of Pull Request
Please describe:
Related to Existing Issues
Closes #91
Closes #191
Closes #193
Test and Documentation Coverage
Since this change introduces new API calls I've added additional test cases or modified existing ones where appropriate
TestAccResourceVcfClusterCreate-> modified to use domain name. There are other tests for this resource that still use the ID.TestAccResourceEdgeCluster_basic-> new test that uses the new attribute for compute cluster name. This one doubles as a test for the minimum set of inputs for this resource.TestAccResourceVcfHost_networkPoolName-> new testFor bug fixes or features:
Breaking Changes?