feat: add fqdn
parameter for r/csr
#196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Pull Request
The resource for generating certificate signing requests accepts a resource type and automatically determines the correct FQDN for the request. This only works for resources of type VCENTER due to a limitation in the underlying API.
To resolve this we have to switch to an API andpoint that returns the full set of possible resources. Unfortunately in 5.1.1 this is not possible because this endpoint is not public.
A public endpoint will be available in an upcoming VCF release.
But even if we wait and try to fix this later we would encounter another problem. Some resources can have multiple instances (NSX for example). It would not be possible for the provider to determine which FQDN to use.
The only complete solution would be to explicitly provide the FQDN for the CSR as an input attribute of the resource.
Type of Pull Request
Please describe:
Related to Existing Issues
Closes #195
Test and Documentation Coverage
I have added additional test cases for
vcf_csr
andvcf_certificate
For bug fixes or features:
Breaking Changes?
The identifiers for existing CSR resources will no longer be valid.
User's will have to regenerate their CSRs.