Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fqdn parameter for r/csr #196

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: add fqdn parameter for r/csr #196

merged 1 commit into from
Jul 8, 2024

Conversation

spacegospod
Copy link
Contributor

@spacegospod spacegospod commented Jul 4, 2024

Summary of Pull Request

The resource for generating certificate signing requests accepts a resource type and automatically determines the correct FQDN for the request. This only works for resources of type VCENTER due to a limitation in the underlying API.

To resolve this we have to switch to an API andpoint that returns the full set of possible resources. Unfortunately in 5.1.1 this is not possible because this endpoint is not public.
A public endpoint will be available in an upcoming VCF release.

But even if we wait and try to fix this later we would encounter another problem. Some resources can have multiple instances (NSX for example). It would not be possible for the provider to determine which FQDN to use.

The only complete solution would be to explicitly provide the FQDN for the CSR as an input attribute of the resource.

Type of Pull Request

  • This is a bug fix.
  • This is an enhancement or feature.
  • This is a code style/formatting update.
  • This is a documentation update.
  • This is a refactoring update.
  • This is a chore update
  • This is something else.
    Please describe:

Related to Existing Issues

Closes #195

Test and Documentation Coverage

I have added additional test cases for vcf_csr and vcf_certificate

For bug fixes or features:

  • Tests have been completed.
  • Documentation has been added/updated.

Breaking Changes?

  • Yes, there are breaking changes.
  • No, there are no breaking changes.

The identifiers for existing CSR resources will no longer be valid.
User's will have to regenerate their CSRs.

@spacegospod spacegospod self-assigned this Jul 4, 2024
@github-actions github-actions bot added documentation Documentation needs-review Needs Review provider labels Jul 4, 2024
@spacegospod spacegospod changed the title feat: add a new parameter for resource FQDN feat: add a new parameter for resource FQDN in VCF_CSR Jul 4, 2024
@tenthirtyam tenthirtyam self-requested a review July 5, 2024 14:01
@tenthirtyam tenthirtyam added bug Bug enhancement Enhancement breaking-change Breaking Change labels Jul 5, 2024
Copy link
Contributor

@tenthirtyam tenthirtyam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've added the breaking-change label to the pull request so let's be sure to make this a minor release vs patch - 0.10.0 - and include a Breaking Change section at the top of the CHANGELOG.md on release.

@tenthirtyam tenthirtyam added this to the 0.10.0 milestone Jul 5, 2024
@tenthirtyam tenthirtyam changed the title feat: add a new parameter for resource FQDN in VCF_CSR feat: add fqdn parameter for r/csr Jul 5, 2024
@tenthirtyam tenthirtyam removed the needs-review Needs Review label Jul 5, 2024
@spacegospod spacegospod merged commit 7638290 into main Jul 8, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Breaking Change bug Bug documentation Documentation enhancement Enhancement provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

r/csr fails for SDDC_MANAGER and NSXT_MANAGER
2 participants