[Task IAC-805] Improved code coverage

Signed-off-by: Alexander Kantchev <[email protected]>
vmware · Jan 18, 2024 · b010d79 · b010d79
1 parent ee6e15b
commit b010d79
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/.vscode/settings.json b/.vscode/settings.json
@@ -16,7 +16,7 @@
     "**/build/azure-pipelines/**/*.yml": "azure-pipelines"
   },
   "editor.codeActionsOnSave": {
-    "source.fixAll.eslint": true
+    "source.fixAll.eslint": "explicit"
   },
   "eslint.validate": ["javascript", "typescript"],
 

diff --git a/packages/node/vrdt-common/src/platform/BaseConfiguration.ts b/packages/node/vrdt-common/src/platform/BaseConfiguration.ts
@@ -22,20 +22,19 @@ export abstract class BaseConfiguration {
         return this.getActiveProfileImpl()
     }
 
-    get pluginSettings(): VrealizeSettings {
-        return this.vrdev
-    }
-
     private getActiveProfileImpl(): MavenProfileWrapper {
         const profileName = this.vrdev.maven.profile
 
         if (!profileName) {
             throw new Error("There is no currently active maven profile. Set the 'vrdev.maven.profile' setting")
         }
+
         if (!this.allProfiles) {
             throw new Error("There are no vRO profiles in ~/.m2/settings.xml")
         }
+
         const profile = this.allProfiles[profileName]
+
         if (!profile) {
             throw new Error(`Could not find profile '${profileName}' in ~/.m2/settings.xml`)
         }

diff --git a/packages/node/vrdt-common/src/rest/VroRestClient.ts b/packages/node/vrdt-common/src/rest/VroRestClient.ts
@@ -43,7 +43,7 @@ export class VroRestClient {
 
     constructor(private settings: BaseConfiguration) {
         this.auth = this.getInitialAuth()
-        this.isCachingEnabled = this.settings?.pluginSettings?.vro?.inventory?.cache ?? false
+        this.isCachingEnabled = this.settings?.vrdev?.vro?.inventory?.cache ?? false
     }
 
     private get hostname(): string {