Add parametric UMAP model family #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion_dataset function
…t a parameter of this function
…tion_dataframe', and add function 'vak.prep.split.unit_dataframe'
…classification.prep_frame_classification_dataset
… 'move_files_into_split_subdirs'
…_reduction/__init__.py
…dataset` to use `dataset_arrays.move_array_files_into_split_dirs` and `Metadata`
…_umap/parametric_umap.py
…odels/__init__.py
…or_tests/configs/configs.json
…er default to None, fix parameter order in docstring
…ests/configs/ConvEncoderUMAP_eval_audio_cbin_annot_notmat.toml
… make it return the shape of all spectrograms
…c_umap/parametric_umap.py and use with Metadata
…o come before audio_format
…t to tuple when we load from json
…py, to use in train.parametric_umap, eval.parametric_umap, etc.
… transform if 'padding' is in the transform_kwargs
… in the right place, before we get the transforms with it
…oder UMAP, remove spect_scaler_path since it's not used
…etric_umap_model' inside vak.cli.eval
…frames_dataset.py
…window_dataset.py
….py, rename ParametricUMAPDataset -> ParametricUMAPTrainingDatset, and add ParametricUMAPInferenceDataset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #631. It's not actually complete but I need to clean up the codebase and fix unit tests so @marisbasha has a good base to work from for #674. I also need to get in a fix for #687. I will make a new issue that lists remaining tasks for adding Parametric UMAP and come back to that after cleaning up.
edit: issue to finish up is #689