Merge pull request #215 from munen/bugfix/73385046/raise-on-failed-state

raise an error if api/talks#update fails to set state

app/controllers/api/talks_controller.rb

@@ -26,6 +26,14 @@ def update
     # TODO check for security issue (whitelist methods)
     msg = send @method, msg if respond_to? @method
 
+    # this is critical, so raise an error if it fails
+    if validate_state(state)
+      raise "Critical: Failed to set state #{state} " +
+            "for user #{current_user.id} " +
+            "on talk #{@talk.id} " +
+            "with method #{@method}"
+    end
+
     publish msg.to_hash
     head :ok
   end
@@ -95,4 +103,8 @@ def verified_request?
     super || form_authenticity_token == request.headers['X-XSRF-TOKEN']
   end
 
+  def validate_state(state)
+    state && state != @talk.reload.session[current_user.id][:state]
+  end
+
 end

spec/controllers/api/talks_controller_spec.rb

@@ -30,6 +30,13 @@
         response.status.should be(422)
       end
 
+      it 'raises error when state cannot be set' do
+        Api::TalksController.any_instance.stub(:validate_state).and_raise
+        expect {
+          put :update, id: @talk.id, msg: { state: 'WaitingForPromotion' }
+        }.to raise_error
+      end
+
     end
 
     # as host sending events for other user