fix: fix static check failures

cli/cli.go

@@ -13,6 +13,8 @@ import (
 	"github.com/urfave/cli/v2"
 	"github.com/voidint/g/build"
 	"github.com/voidint/g/version"
+	"golang.org/x/text/cases"
+	"golang.org/x/text/language"
 )
 
 var (
@@ -37,11 +39,11 @@ func Run() {
 		ghomeDir = ghome()
 		goroot = filepath.Join(ghomeDir, "go")
 		downloadsDir = filepath.Join(ghomeDir, "downloads")
-		if err = os.MkdirAll(downloadsDir, 0755); err != nil {
+		if err = os.MkdirAll(downloadsDir, 0750); err != nil {
 			return err
 		}
 		versionsDir = filepath.Join(ghomeDir, "versions")
-		return os.MkdirAll(versionsDir, 0755)
+		return os.MkdirAll(versionsDir, 0750)
 	}
 	app.Commands = commands
 
@@ -132,7 +134,7 @@ type versionOut struct {
 }
 
 const (
-	rawMode  = 0
+	textMode = 0
 	jsonMode = 1
 )
 
@@ -156,18 +158,18 @@ func render(mode uint8, installed map[string]bool, items []*version.Version, out
 
 		enc := json.NewEncoder(out)
 		enc.SetIndent("", "    ")
-		enc.Encode(&vs)
+		_ = enc.Encode(&vs)
 
 	default:
 		for _, item := range items {
 			if inused, found := installed[item.Name()]; found {
 				if inused {
-					color.New(color.FgGreen).Fprintf(out, "* %s\n", item.Name())
+					_, _ = color.New(color.FgGreen).Fprintf(out, "* %s\n", item.Name())
 				} else {
-					color.New(color.FgGreen).Fprintf(out, "  %s\n", item.Name())
+					_, _ = color.New(color.FgGreen).Fprintf(out, "  %s\n", item.Name())
 				}
 			} else {
-				fmt.Fprintf(out, "  %s\n", item.Name())
+				_, _ = fmt.Fprintf(out, "  %s\n", item.Name())
 			}
 		}
 	}
@@ -187,7 +189,7 @@ func wrapstring(str string) string {
 	}
 	words := strings.Fields(str)
 	if len(words) > 0 {
-		words[0] = strings.Title(words[0])
+		words[0] = cases.Title(language.English).String(words[0])
 	}
 	return fmt.Sprintf("[g] %s", strings.Join(words, " "))
 }

cli/cli_test.go

@@ -51,7 +51,7 @@ func Test_render(t *testing.T) {
 		}
 		sort.Sort(version.Collection(items))
 
-		render(rawMode, map[string]bool{"1.8.1": true}, items, &buf)
+		render(textMode, map[string]bool{"1.8.1": true}, items, &buf)
 		assert.Equal(t, "  1.7\n* 1.8.1\n  1.10beta2\n  1.19beta1\n  1.21rc4\n  1.21.0\n", buf.String())
 	})
 }

cli/commands.go

@@ -13,7 +13,7 @@ var (
 				&cli.StringFlag{
 					Name:    "output",
 					Aliases: []string{"o"},
-					Usage:   "Output format. One of: (raw, json).",
+					Usage:   "Output format. One of: (text, json).",
 				},
 			},
 			Action: list,
@@ -27,7 +27,7 @@ var (
 				&cli.StringFlag{
 					Name:    "output",
 					Aliases: []string{"o"},
-					Usage:   "Output format. One of: (raw, json).",
+					Usage:   "Output format. One of: (text, json).",
 				},
 			},
 			Action: listRemote,

cli/ls.go

@@ -35,7 +35,7 @@ func list(ctx *cli.Context) (err error) {
 	case "json":
 		renderMode = jsonMode
 	default:
-		renderMode = rawMode
+		renderMode = textMode
 	}
 
 	render(renderMode, installed(), items, ansi.NewAnsiStdout())

cli/ls_remote.go

@@ -68,7 +68,7 @@ func listRemote(ctx *cli.Context) (err error) {
 	case "json":
 		renderMode = jsonMode
 	default:
-		renderMode = rawMode
+		renderMode = textMode
 	}
 
 	render(renderMode, installed(), vs, ansi.NewAnsiStdout())

collector/aliyun/aliyun_collector.go

@@ -78,7 +78,7 @@ func (c *Collector) ArchivedVersions() (items []*version.Version, err error) {
 func (c *Collector) AllVersions() (vers []*version.Version, err error) {
 	items := c.findGoFileItems(c.doc.Find(".table"))
 	if len(items) == 0 {
-		return make([]*version.Version, 0, 0), nil
+		return make([]*version.Version, 0), nil
 	}
 	if vers, err = convert2Versions(items); err != nil {
 		return nil, err

go.mod

@@ -15,6 +15,7 @@ require (
 	github.com/stretchr/testify v1.8.4
 	github.com/urfave/cli/v2 v2.25.7
 	github.com/voidint/go-update v1.0.0
+	golang.org/x/text v0.14.0
 )
 
 require (

go.sum

@@ -134,6 +134,8 @@ golang.org/x/text v0.3.6/go.mod h1:5Zoc/QRtKVWzQhOtBMvqHzDpF6irO9z98xDceosuGiQ=
 golang.org/x/text v0.3.7/go.mod h1:u+2+/6zg+i71rQMx5EYifcz6MCKuco9NR6JIITiCfzQ=
 golang.org/x/text v0.7.0/go.mod h1:mrYo+phRRbMaCq/xk9113O4dZlRixOauAjOtrjsXDZ8=
 golang.org/x/text v0.9.0/go.mod h1:e1OnstbJyHTd6l/uOt8jFFHp6TRDWZR/bV3emEE/zU8=
+golang.org/x/text v0.14.0 h1:ScX5w1eTa3QqT8oi6+ziP7dTV1S2+ALU0bI+0zXKWiQ=
+golang.org/x/text v0.14.0/go.mod h1:18ZOQIKpY8NJVqYksKHtTdi31H5itFRjB5/qKTNYzSU=
 golang.org/x/tools v0.0.0-20180917221912-90fa682c2a6e/go.mod h1:n7NCudcB/nEzxVGmLbDWY5pfWTLqBcC2KZ6jyYvM4mQ=
 golang.org/x/tools v0.0.0-20191119224855-298f0cb1881e/go.mod h1:b+2E5dAYhXwXZwtnZ6UAqBI28+e2cm9otk0dWdXHAEo=
 golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc=

pkg/errs/error.go

@@ -39,7 +39,7 @@ func NewPackageNotFoundError(kind, goos, goarch string) error {
 }
 
 func (e PackageNotFoundError) Error() string {
-	return fmt.Sprintf("Package not found [%s,%s,%s]", e.goos, e.goarch, e.kind)
+	return fmt.Sprintf("package not found [%s,%s,%s]", e.goos, e.goarch, e.kind)
 }
 
 // VersionNotFoundError 版本不存在错误
@@ -66,7 +66,7 @@ func NewVersionNotFoundError(version, goos, goarch string) error {
 }
 
 func (e VersionNotFoundError) Error() string {
-	return fmt.Sprintf("Version not found %q [%s,%s]", e.version, e.goos, e.goarch)
+	return fmt.Sprintf("version not found %q [%s,%s]", e.version, e.goos, e.goarch)
 }
 
 func (e VersionNotFoundError) Version() string {
@@ -87,7 +87,7 @@ func NewMalformedVersionError(version string, err error) error {
 }
 
 func (e MalformedVersionError) Error() string {
-	return fmt.Sprintf("Malformed version string %q", e.version)
+	return fmt.Sprintf("malformed version string %q", e.version)
 }
 
 func (e MalformedVersionError) Err() error {
@@ -146,7 +146,7 @@ func NewDownloadError(url string, err error) error {
 // Error 返回错误字符串
 func (e DownloadError) Error() string {
 	var buf strings.Builder
-	buf.WriteString(fmt.Sprintf("Resource(%s) download failed", e.url))
+	buf.WriteString(fmt.Sprintf("resource(%s) download failed", e.url))
 	if e.err != nil {
 		buf.WriteString(" ==> " + e.err.Error())
 	}

pkg/errs/error_test.go

@@ -37,6 +37,6 @@ func TestDownloadError(t *testing.T) {
 		assert.NotNil(t, e)
 		assert.Equal(t, url, e.URL())
 		assert.Equal(t, core, e.Err())
-		assert.Equal(t, fmt.Sprintf("Resource(%s) download failed ==> %s", url, core.Error()), e.Error())
+		assert.Equal(t, fmt.Sprintf("resource(%s) download failed ==> %s", url, core.Error()), e.Error())
 	})
 }

version/finder.go

@@ -39,8 +39,8 @@ func NewFinder(items []*Version, opts ...func(fdr *Finder)) *Finder {
 		items:  items,
 	}
 
-	if opts != nil {
-		for _, setter := range opts {
+	for _, setter := range opts {
+		if opts != nil {
 			setter(&fdr)
 		}
 	}

version/version_test.go

@@ -145,7 +145,7 @@ func TestVerifyChecksum(t *testing.T) {
 		})
 
 		t.Run("校验和不匹配", func(t *testing.T) {
-			f.Seek(0, 0)
+			_, _ = f.Seek(0, 0)
 			h := sha1.New()
 			_, err = io.Copy(h, f)
 			assert.Nil(t, err)
@@ -158,7 +158,7 @@ func TestVerifyChecksum(t *testing.T) {
 		})
 
 		t.Run("SHA1", func(t *testing.T) {
-			f.Seek(0, 0)
+			_, _ = f.Seek(0, 0)
 			h := sha1.New()
 			_, err = io.Copy(h, f)
 			assert.Nil(t, err)