docs(rfc): propose vp toolchain inspection command#2111
Draft
fengmk2 wants to merge 1 commit into
Draft
Conversation
✅ Deploy Preview for viteplus-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Native binary sizes (
|
| Artifact | Format | Base | PR | Change |
|---|---|---|---|---|
vp (Linux x64) |
Binary | 10.28 MiB | 10.27 MiB | -8.00 KiB (-0.08%) |
vp (Linux x64) |
gzip -9 | 4.41 MiB | 4.41 MiB | -2.17 KiB (-0.05%) |
| NAPI (Linux x64) | Binary | 33.41 MiB | 33.42 MiB | +3.94 KiB (+0.01%) |
| NAPI (Linux x64) | gzip -9 | 12.78 MiB | 12.77 MiB | -9.44 KiB (-0.07%) |
vp (macOS ARM64) |
Binary | 7.61 MiB | 7.61 MiB | -32 B (-0.00%) |
vp (macOS ARM64) |
gzip -9 | 3.83 MiB | 3.82 MiB | -9.83 KiB (-0.25%) |
| NAPI (macOS ARM64) | Binary | 40.77 MiB | 40.78 MiB | +16.39 KiB (+0.04%) |
| NAPI (macOS ARM64) | gzip -9 | 17.04 MiB | 17.02 MiB | -27.23 KiB (-0.16%) |
vp (Windows x64) |
Binary | 8.33 MiB | 8.32 MiB | -9.00 KiB (-0.11%) |
vp (Windows x64) |
gzip -9 | 3.63 MiB | 3.63 MiB | -1,020 B (-0.03%) |
| NAPI (Windows x64) | Binary | 27.86 MiB | 27.85 MiB | -8.00 KiB (-0.03%) |
| NAPI (Windows x64) | gzip -9 | 10.78 MiB | 10.76 MiB | -21.01 KiB (-0.19%) |
| Trampoline (Windows x64) | Binary | 203.00 KiB | 203.00 KiB | 0 B (0.00%) |
| Trampoline (Windows x64) | gzip -9 | 97.91 KiB | 97.91 KiB | +1 B (+0.00%) |
| Installer (Windows x64) | Binary | 4.46 MiB | 4.45 MiB | -5.00 KiB (-0.11%) |
| Installer (Windows x64) | gzip -9 | 2.08 MiB | 2.08 MiB | -1.35 KiB (-0.06%) |
fengmk2
added a commit
that referenced
this pull request
Jul 10, 2026
The size gate compared the PR head against the current tip of the base branch. A branch that forked before a native-input change landed on main failed the hash comparison and got a six-platform rebuild plus a size report whose deltas came from commits already on main. #2111 hit this: an RFC-only PR received the size report for the #2104 dependency upgrade. The gate now resolves the merge base and both compares and builds against it. The build runs only when the PR itself changes a native input, and the report covers only the PR's own delta. PRs that edit this workflow file still trigger a run. The run on this PR exercised the new path end to end: base built at the merge base, head at the PR, and the size report shows 0 B raw delta on every artifact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proposes a new
vp toolchaincommand for inspecting versions and relationships that package managers cannot see, including bundled and compiled components.This PR contains the RFC only. It does not implement the command.
Review focus
vp whydiscovery hintValidation
jq