fix(env): clarify the use case of vp-use.cmd#2128
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
liangmiQwQ
changed the title
vp-use.cmd
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d946fe72eb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
create_env_files ran before bin existed on a fresh VP_HOME, so initial setup skipped the CMD wrapper. Create it after bin initialization and cover the fresh setup path.
|
@codex review |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
ci hang issue will be fixed in #2115 |
|
Okay, updated |
2 participants
vp env setupcurrently createsvp-use.cmdon every platform even though the wrapper is only usable from Windows Command Prompt. Its writer also runs beforeVP_HOME/binis created, so setup skips the wrapper when starting from a fresh home. The CMD-specific version-switching command is also missing from the public environment guide.This PR creates
vp-use.cmdalongside the Windows shims after the bin directory is initialized, adds regression coverage for fresh Windows setup and Unix exclusion, and documents how to usevp-usefrom Command Prompt.🤖 Generated with Codex