fix(cli): avoid debug formatting in user output#2130
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f71d7f49ef
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Restore Debug formatting for user-controlled package manager values. Raw interpolation allowed control characters to create spoofed diagnostic lines; Debug keeps the intended quotes while escaping the contents.
|
@codex review |
|
Codex Review: Didn't find any major issues. Chef's kiss. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Some user-facing Vite+ diagnostics rely on Rust's
Debugformatting. This can expose implementation details such asSome(1)for a failed process status and wrapper types around paths.This PR uses display formatting for Vite+-owned paths and process statuses, while keeping explicit quotes in package-manager diagnostics and preserving developer-only debug traces. Failed global installs now report
exit status: 1.There is still follow-up work in Vite Task. In particular,
vite_workspace::Error::PackageJsonNotFoundcurrently uses{0:?}and can render paths asAbsolutePathBuf("/path"). That formatter and the sibling user-facingDebugformatters invite_workspaceshould be fixed upstream, followed by updating Vite+'s pinned Vite Task revision.🤖 Generated with Codex