test(snapshots): remove legacy snapshot infrastructure#2146
Merged
fengmk2 merged 2 commits intoJul 10, 2026
Conversation
Drop the obsolete runner, migration tooling, scripts, dependencies, and configuration now that CLI snapshots run exclusively through the PTY suite.
Remove migration-era guidance and update active documentation, skills, and code comments to describe the PTY snapshot workflow only.
✅ Deploy Preview for viteplus-preview canceled.
|
Collaborator
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Keep them coming! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
fengmk2
approved these changes
Jul 10, 2026
Collaborator
|
We finally make it! 💯 |
Collaborator
Author
It's really amazing work 💜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PTY snapshot suite is now the only supported path for CLI snapshot testing. The obsolete runner and one-time migration tooling are removed, and repository workflows,configuration, and contributor guidance no longer maintain dual-suite behavior.
pnpm testnow runs the unit suite without invoking empty legacy trees, while CLI snapshot coverage continues throughjust snapshot-test. Historical RFC references remain unchanged as implementation records.Closes #2136.