fix(cli): always append node path when spawning child pm process#2158
fix(cli): always append node path when spawning child pm process#2158BlankParticle wants to merge 3 commits into
Conversation
✅ Deploy Preview for viteplus-preview canceled.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0e372e3837
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
💜 I don't find other major problems, let Codex find whether there is any other edge case. @codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c631fbe25b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
liangmiQwQ
left a comment
liangmiQwQ
left a comment
There was a problem hiding this comment.
Since the other team members may be busy these days, I can’t make sure when your PR will be merged. Thanks for your contribution 💯
3 participants
fixes #2157
there was a gated case where in case of Bun package manager, appending node to
PATHwas being skipped, so if the child bun process tried to spawn node processvpwould see that its running inside of anothervpprocess but as there is no node path appended, it would crashI fixed this problem by always appending node path to the child pm
the only change is removing the Bun guard case, else if related cleanup, whitespace changes and added tests