Skip to content

Commit

Permalink
Do not clean up kernel resources after execution (#1334)
Browse files Browse the repository at this point in the history
* Do not clean up resources after execution

Revert #969

This should never have been merged. The client still needs the kernel
and channels running after execution !

Co-authored-by: davidbrochart <[email protected]>

* Only clean the kernel client

---------

Co-authored-by: davidbrochart <[email protected]>
  • Loading branch information
martinRenou and davidbrochart authored Jun 28, 2023
1 parent a457763 commit 8ee8aeb
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion voila/notebook_renderer.py
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ async def _jinja_cell_generator(self, nb, kernel_id):
await self._cleanup_resources()

async def _cleanup_resources(self):
await ensure_async(self.executor.km.cleanup_resources())
await ensure_async(self.executor.kc.stop_channels())

async def load_notebook(self, path):
Expand Down

0 comments on commit 8ee8aeb

Please sign in to comment.