Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make voila compatible with jupyterlab 4 #1304

Closed
3 tasks done
trungleduc opened this issue Mar 16, 2023 · 6 comments · Fixed by #1308
Closed
3 tasks done

Make voila compatible with jupyterlab 4 #1304

trungleduc opened this issue Mar 16, 2023 · 6 comments · Fixed by #1308
Assignees
Labels
api-change enhancement New feature or request
Milestone

Comments

@trungleduc
Copy link
Member

trungleduc commented Mar 16, 2023

Problem

Since JupyterLab 4.0 is just around the corner, I think for the next release (0.5.0), voila should be compatible with lab 4 and not lab 3.

Proposed Solution

@trungleduc trungleduc added enhancement New feature or request api-change labels Mar 16, 2023
@trungleduc trungleduc added this to the 0.5.0 milestone Mar 16, 2023
@jtpio
Copy link
Member

jtpio commented Mar 16, 2023

Posting here one of the comments from #846 which could be addressed by updating to lab 4 packages:

We should now be able to update to the 4.0.0-alpha.x JupyterLab packages, which include the change from jupyterlab/jupyterlab#11537 to allow for mock services.

@jtpio
Copy link
Member

jtpio commented May 16, 2023

FYI JupyterLab 4 final has been released: https://github.com/jupyterlab/jupyterlab/releases/tag/v4.0.0

@martinRenou
Copy link
Member

We may be stuck waiting for ipywidgets to support lab 4 before being able to update Voila

@trungleduc
Copy link
Member Author

for the ipywidgets PR, a simple version bump is enough?

@martinRenou
Copy link
Member

Hopefully, some attempts have been made https://github.com/jupyter-widgets/ipywidgets/pull/3752/files

Galata needs to be updated there too

@jtpio
Copy link
Member

jtpio commented Jun 8, 2023

As part of the update of the Voila Preview extension for JupyterLab, it would also be useful to use the type property when adding a preview to the main area. So end users could decide to open the preview in a different area if they would like to (via the settings).

This functionality was added to JupyterLab in jupyterlab/jupyterlab#11614.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants