feat: add gitPushOptions and gitPushTagOptions. #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slabruyere
force-pushed
the
feat/add-push-options
branch
from
680bee1 to
10d2adc
Compare
|
Awesome! Thanks @mojoaxel |
eddiemonge
reviewed
Apr 10, 2018
| @@ -254,12 +256,12 @@ module.exports = function(grunt) { | |||
| cmd = []; | |||
|
|
|||
| if (opts.push === true || opts.push === 'branch') { | |||
| cmd.push('git push ' + opts.pushTo + ' ' + ref.trim()); | |||
| cmd.push('git push ' + opts.pushTo + ' ' + ref.trim() + ' ' + opts.gitPushOptions); | |||
There was a problem hiding this comment.
shouldn't the options go before the refs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added option
gitPushOptionsadded option
gitPushTagOptionsAn interesting use case is for instance if you have a
pre-pushgit hook that runs your tests and CI that doesn't let you merge your PRs if the tests fail. Then you don't want your tests to run just for a version bump (which usually happens after a checked merge).The proposed solution is, in this case, to set the
gitPushOptionsto--no-verify.I also added a
gitPushTagOptionsin case it's of some use for some people :)