Http features#17
Open
download13 wants to merge 2 commits intovojtajina:masterfrom
download13:http-features
Open
Http features#17download13 wants to merge 2 commits intovojtajina:masterfrom download13:http-features
download13 wants to merge 2 commits intovojtajina:masterfrom
download13:http-features
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
writeHeadmethod didn't take the arguments for status text and headers, so I added those.Also changed the header names to be lower-case since that's how node core does it.
Oh right, and there's also the getDebugData function to get it all back since it's not usually a good idea to poke at the prefixed implementation details of an object.
I can change some of this if that's not how it's supposed to work here.