Skip to content

change twitter to x #408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
Merged

change twitter to x #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/_default/languages.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@

[[zh.menu.main_right]]
name = "<i class=\"fab fa-x-twitter\" style=\"color: #000000; font-size: 1rem; line-height: 1.25\"></i>"
url = "https://twitter.com/volcano_sh"
url = "https://x.com/volcano_sh"
weight = 20

[[zh.menu.main_right]]
Expand Down
2 changes: 1 addition & 1 deletion config/_default/menus.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@
[[main_right]]
name = "<i class=\"fab fa-x-twitter\" style=\"color: #000000; font-size: 1rem; line-height: 1.25\"></i>"
post = ""
url = "https://twitter.com/volcano_sh"
url = "https://x.com/volcano_sh"
weight = 20

[[main_right]]
Expand Down
2 changes: 1 addition & 1 deletion content/en/author/volcano/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ interests = []
[[social]]
icon = "/img/icon_twitter.svg"
icon_pack = "fab"
link = "https://twitter.com/volcano_sh"
link = "https://x.com/volcano_sh"
Copy link

@gemini-code-assist gemini-code-assist bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While the link has been correctly updated to x.com, the associated icon on line 39 still refers to icon_twitter.svg. This is inconsistent with the change from Twitter to X.

To make the change complete, please consider renaming the icon_twitter.svg file to something more appropriate like icon_x.svg (and updating its content to the X logo), and then update the path on line 39.


+++
<div class="about-volcano">
Expand Down
2 changes: 1 addition & 1 deletion content/zh/author/volcano/_index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ interests = []
[[social]]
icon = "/img/icon_twitter.svg"
icon_pack = "fab"
link = "https://twitter.com/volcano_sh"
link = "https://x.com/volcano_sh"
Copy link

@gemini-code-assist gemini-code-assist bot Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the English author page, the link is correctly updated, but the icon on line 39 (icon = "/img/icon_twitter.svg") is now inconsistent.

To complete the branding update from Twitter to X, please also update the icon file and its path on line 39.


+++
<div class="about-volcano">
Expand Down