feat(sessions): support specifying session_id when creating session#1074
Merged
qin-ctx merged 2 commits intovolcengine:mainfrom Apr 3, 2026
Merged
Conversation
|
Failed to generate code suggestions for PR |
|
|
Contributor
Author
|
@qin-ctx hello，有空帮看眼 |
Collaborator
|
@likzn 我在想要不要保留 create_session，因为我在 get_session 里已经实现了 auto_create 的逻辑。如果 create_session 仍然保留，那就需要严格检查该 sessio_id 是全新的，没有被使用。 |
Contributor
Author
我理解为了向前兼容性是不是应该继续保留，理论上自定义id的方法放在create看起来更合适，晚点我补充下id的校验 |
Add AlreadyExistsError check in session_service.create() when a specific session_id is provided, ensuring idempotent behavior and preventing accidental overwrites of existing sessions.
Contributor
Author
|
id校验已加。 @qin-ctx |
qin-ctx
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Support specifying a custom session_id when creating a session. Previously, create_session() did not accept a session_id parameter. Now you can pass a specified ID to create a session, consistent with the behavior of get_session(session_id, auto_create=True).
Reference issue: #1065
Type of Change
Testing
Related Issues
Checklist