[codex] Disable AGFS management API by default#1132
Closed
13ernkastel wants to merge 1 commit intovolcengine:mainfrom
Closed
[codex] Disable AGFS management API by default#113213ernkastel wants to merge 1 commit intovolcengine:mainfrom
13ernkastel wants to merge 1 commit intovolcengine:mainfrom
Conversation
PR Code Suggestions ✨No code suggestions found for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
server.management_api_enabledflagWhy
The bundled AGFS server exposes a control-plane surface for runtime mount changes and external plugin loading. In a network-exposed deployment, leaving that surface available by default increases risk because it allows live filesystem and plugin reconfiguration over HTTP. This change keeps the capability available for trusted admin networks while making the secure default explicit.
Impact
server.management_api_enabled: trueValidation
pkg/handlers/plugin_handlers_test.gogit diff --checkpasses locallygo testandgofmtwere not run in this environment because the Go toolchain is not installed