feat(cli): improve chat endpoint configuration priority#1143
Merged
chenjw merged 1 commit intovolcengine:mainfrom Apr 1, 2026
Merged
feat(cli): improve chat endpoint configuration priority#1143chenjw merged 1 commit intovolcengine:mainfrom
chenjw merged 1 commit intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
- Add priority system for chat endpoint: VIKINGBOT_ENDPOINT > OPENVIKING_URL/bot/v1 > config.url/bot/v1 - Add start_server.py helper script for development with hot reload support
034c963 to
e8dfeb1
Compare
chenjw
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
ov chatcommand does not use the URL defined inovcli.conf.ovcli.conf
{ "url": "http://192.168.1.1:1933", "api_key": "xxx", "timeout": 60.0, "output": "table" }Summary
Improve ov CLI chat command endpoint configuration logic with new configuration priority support and add a helper script for starting the server.
Changes:
ov CLI chat command endpoint configuration optimization (
crates/ov_cli/src/main.rs)VIKINGBOT_ENDPOINTenv var >OPENVIKING_URLenv var +/bot/v1> config fileurl+/bot/v1VIKINGBOT_ENDPOINTenv var or hardcoded default valueOPENVIKING_URLenv varNew server startup script (
start_server.py)Type of Change
Checklist