feat(retrieve): use tags metadata for cross-subtree retrieval#1162
Open
13ernkastel wants to merge 3 commits intovolcengine:mainfrom
Open
feat(retrieve): use tags metadata for cross-subtree retrieval#116213ernkastel wants to merge 3 commits intovolcengine:mainfrom
13ernkastel wants to merge 3 commits intovolcengine:mainfrom
Conversation
|
Failed to generate code suggestions for PR |
|
Failed to generate code suggestions for PR |
Collaborator
|
我建议对 tag 的内容命名进行约束,例如强制声明 tag 来源或原因: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HierarchicalRetrieverwith bounded, down-weighted tag-based cross-subtree discovery before BFS traversal startsRelated Issue
Fixes #1147
Why
Issue #1147 asks for tags to act as a lateral discovery signal across semantically distant subtrees. This keeps the existing hierarchical retrieval flow, but gives it a controlled way to discover related branches that the initial semantic top-K would otherwise miss.
Impact
Validation
PYTHONPATH=/Users/lennonchia/Documents/Project/OpenViking /Users/lennonchia/Documents/Project/OpenViking/.venv/bin/python -m pytest -q tests/retrieve/test_hierarchical_retriever_target_dirs.py tests/retrieve/test_hierarchical_retriever_rerank.py tests/retrieve/test_hierarchical_retriever_tags.py tests/server/test_api_search.py::test_find_forwards_tags_to_service tests/server/test_api_resources.py::test_add_resource_forwards_tags_to_serviceNotes
tests/server/test_api_search.pysuite locally, but the current local wheel is missing the native VectorDBPersistStoresymbol, so full end-to-end vector search verification is still environment-dependent here.