Skip to content

fix: resolve commitInFlight 404 bug and assistant role data loss #1167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Boes-man wants to merge 1 commit into
base: main
Choose a base branch
from
+23 −1
Open

fix: resolve commitInFlight 404 bug and assistant role data loss #1167

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 23 additions & 1 deletion examples/opencode-memory-plugin/openviking-memory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,6 +1019,19 @@ async function pollCommitTaskOnce(

return task.status
} catch (error: any) {
// If task not found (404/expired), clear commit state so new commits can proceed
if (error.message?.includes("not found") || error.message?.includes("404")) {
log("INFO", "session", "Commit task expired or not found, clearing commit state", {
openviking_session: mapping.ovSessionId,
opencode_session: opencodeSessionId,
task_id: mapping.commitTaskId,
error: error.message,
})
clearCommitState(mapping)
debouncedSaveSessionMap()
return "completed"
}

log("ERROR", "session", "Failed to poll OpenViking background commit", {
openviking_session: mapping.ovSessionId,
opencode_session: opencodeSessionId,
Expand Down Expand Up @@ -1454,7 +1467,7 @@ export const OpenVikingMemoryPlugin = async (input: PluginInput): Promise<Hooks>
role: role,
})
}
} else if (role === "assistant" && finish === "stop") {
} else if (role === "assistant") {
mapping.messageRoles.set(messageId, role)

log("DEBUG", "message", `${role} message completed and role stored`, {
Expand All @@ -1463,6 +1476,15 @@ export const OpenVikingMemoryPlugin = async (input: PluginInput): Promise<Hooks>
role: role,
finish: finish,
})

if (finish && finish !== "stop") {
log("INFO", "message", `assistant message role stored with non-stop finish`, {
session_id: sessionId,
message_id: messageId,
role: role,
finish: finish,
})
}
}

await flushPendingMessages(sessionId, mapping, config)
Expand Down