increase seed size to 64 bits #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes official-stockfish#2106 This PR switches from cutechess-cli to fast-chess. cutechess-cli has been serving us well in the past years, however, some issues have accumulated, namely the difficulty of compiling cutechess-cli, the observed timeouts at high concurrency and short TC, and e.g. slowness when indexing larger books. fast-chess https://github.com/Disservin/fast-chess has addressed these issues, and has now probably become mature enough to serve as the game manager for fishtest. As an example of its ability to deal with short TC and high concurrency: https://dfts-0.pigazzini.it/tests/view/669249cdbee8253775cede32 with concurrency 25, and TC 1+0.01s no timeouts are observed. fast-chess is built from sources, with the zip download as well as the binary cached as needed. There is fine-grained control over which version of fast-chess is used, so we can easily upgrade for new features. In this PR, fast-chess is built in cutechess compatibility to facilitate integration, and to benefit from the existing fishtest checks. Once validated, we should be able to switch easily to its native mode, which can output trinomial and pentanomial results, and we should be able significantly simplify the worker's book-keeping. Co-Authored-By: Disservin <[email protected]> Co-Authored-By: Gahtan Nahdi <[email protected]>
vondele
reviewed
Jul 16, 2024
| @@ -1297,7 +1297,7 @@ def run_games( | |||
| if "start" in task: | |||
| print("Variable task sizes used. Opening offset = {}".format(opening_offset)) | |||
| start_game_index = opening_offset + input_total_games | |||
| run_seed = int(hashlib.sha1(run["_id"].encode("utf-8")).hexdigest(), 16) % (2**30) | |||
| run_seed = int(hashlib.sha1(run["_id"].encode("utf-8")).hexdigest(), 16) % (2**64) | |||
There was a problem hiding this comment.
are we sure the result fits a 64bit int, including the sign ?
There was a problem hiding this comment.
Yes, the SHA1 itself is a 160 bit value which is then modulod to 2^64
There was a problem hiding this comment.
my point is that the max size of an 64 bit int is 2^63-1 so if we want to fit it, I don't think we can take modulo 2^64
There was a problem hiding this comment.
my point is that the max size of an 64 bit int is 2^63-1 so if we want to fit it, I don't think we can take modulo 2^64
The max size of a 64 bit (u)int is 2^64-1, which you can get by modulo 2^64
There was a problem hiding this comment.
The result of a modulo operation is always positive
vondele
force-pushed
the
fastchessPR
branch
3 times, most recently
from
43fbd41
to
dc51a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fast chess supports 64 bit seeds which allows for far more unique opening sequences