perf[duckdb]: dict exporter regression #4771
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
added
the
performance
Benchmarks: Random AccessSummary
|
Signed-off-by: Joe Isaacs <[email protected]>
Benchmarks: TPC-H SF=1 on NVMESummary
Detailed Results Table
|
0ax1
reviewed
Sep 25, 2025
vortex-duckdb/src/exporter/dict.rs
Outdated
| let mut vector = Vector::with_capacity(values.dtype().try_into()?, values.len()); | ||
| new_array_exporter(values, cache)?.export(0, values.len(), &mut vector)?; | ||
|
|
||
| // This is a bit of a hack, but we need to create a dictionary vector |
There was a problem hiding this comment.
Please explain in a comment why we do this dance. 🙂
Benchmarks: TPC-H SF=1 on S3Summary
Detailed Results Table
|
0ax1
reviewed
Sep 25, 2025
vortex-duckdb/src/exporter/dict.rs
Outdated
| len, | ||
| ); | ||
|
|
||
| // Use a unique id to each dictionary data array -- telling duckdb that |
There was a problem hiding this comment.
unrelated but can we change this to for each
Benchmarks: CompressionSummary
Detailed Results Table
|
Benchmarks: TPC-H SF=10 on NVMESummary
Detailed Results Table
|
Benchmarks: Statistical and Population GeneticsSummary
Detailed Results Table
|
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Benchmarks: Clickbench on NVMESummary
Detailed Results Table
|
Codecov Report✅ All modified and coverable lines are covered by tests. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarks: TPC-DS SF=1 on NVMESummary
Detailed Results Table
|
Signed-off-by: Joe Isaacs <[email protected]>
# Conflicts: # vortex-duckdb/src/exporter/dict.rs
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joe Isaacs [email protected]