Skip to content

Conversation

joseph-isaacs
Copy link
Contributor

@joseph-isaacs joseph-isaacs commented Oct 10, 2025

Add support for jitting bitpacking, FoR and alp kernels to cuda.

Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs marked this pull request as draft October 10, 2025 20:44
Copy link

Deploying vortex-bench with  Cloudflare Pages  Cloudflare Pages

Latest commit: 916f93e
Status: ✅  Deploy successful!
Preview URL: https://c62bdc1f.vortex-93b.pages.dev
Branch Preview URL: https://ji-jit-bp-for.vortex-93b.pages.dev

View logs

Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.37%. Comparing base (0eea6c8) to head (a81472f).
⚠️ Report is 31 commits behind head on develop.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs added the chore Release label indicating a trivial change label Oct 14, 2025
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs marked this pull request as ready for review October 14, 2025 21:43
@joseph-isaacs joseph-isaacs changed the title wip[gpu]: jit kernels feat[gpu]: jit kernels Oct 14, 2025
Signed-off-by: Joe Isaacs <[email protected]>
PType::I64 => "long long",
PType::F32 => "float",
PType::F64 => "double",
PType::F16 => todo!(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this todo made me go down the rabbit hole https://stackoverflow.com/questions/32735292/can-anyone-provide-sample-code-demonstrating-the-use-of-16-bit-floating-point-in. You need an include and then you can use half but you really want to use half2, i.e. pack two halfs into 32 bits

@robert3005
Copy link
Contributor

Not quite sure how continuation passing style would look like differently? You are nesting the code emitting statements recursively at any given step. You could have a function that will in turn when called emit the code instead of directly emitting the code BUT I can't quite assess in abstract if its easier... maybe?

Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
@joseph-isaacs joseph-isaacs enabled auto-merge (squash) October 16, 2025 16:21
@joseph-isaacs joseph-isaacs merged commit 0e2f209 into develop Oct 16, 2025
65 of 66 checks passed
@joseph-isaacs joseph-isaacs deleted the ji/jit-bp-for branch October 16, 2025 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Release label indicating a trivial change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants