Added support for get promotion tier endpoint #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8e06921.
darekg11
requested changes
May 8, 2023
There was a problem hiding this comment.
Requested changes:
- invalid JSDoc
- incorrect parameter name
- PR is missing CHANGESET file - please read: https://github.com/voucherifyio/voucherify-js-sdk/blob/main/CONTRIBUTING.md#about-changesets-for-contributors
- Please add this new method to examples in: https://github.com/voucherifyio/voucherify-js-sdk/tree/main/packages/sdk#promotions
packages/sdk/src/PromotionTiers.ts
Outdated
| @@ -21,6 +21,12 @@ export class PromotionTiers { | |||
| /** | |||
| * @see https://docs.voucherify.io/reference/add-promotion-tier-to-campaign | |||
| */ | |||
| public get(promotionId: string) { | |||
There was a problem hiding this comment.
Parameter name is misleading.
This endpoint is returning tier based on tierId - https://docs.voucherify.io/reference/get-promotion-tier
Please change parameter name to tierId
packages/sdk/src/PromotionTiers.ts
Outdated
| return this.client.get<T.PromotionTierGetResponse>(`/promotions/tiers/${encode(promotionId)}`) | ||
| } | ||
| /** | ||
| * @see https://docs.voucherify.io/reference/get-promotion-tier |
There was a problem hiding this comment.
This JSdoc is placed above wrong method.
This shuld be above get method
darekg11
approved these changes
May 12, 2023
Merged
|
@p-zielinski thank you for your contribution. Pull request that triggered release: #211 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as the title says.
added support for https://docs.voucherify.io/reference/get-promotion-tier