-
Notifications
You must be signed in to change notification settings - Fork 566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix acceptance test Java version #1093
base: master
Are you sure you want to change the base?
Conversation
Ahhhh, now I understand. The acceptance tests have never worked in the first place. Well time to fix that then (or write new tests) |
If is usefull I use this to install java 21 on my test jenkis setup on a ubuntu 22.04
I haven't checked if everything is necessary |
@@ -1,3 +1,3 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the rename seems wrong, the package name is not common but specific to the RedHat family
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say that https://github.com/voxpupuli/voxpupuli-acceptance/?tab=readme-ov-file#hiera shows the default hierachy, but this module still uses the old voxpupuli-acceptance 2.x where os
really is family
. See voxpupuli/voxpupuli-acceptance@650b642
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it does not since yesterday :)
# Jenkins 2.361.1 requires Java 11 or newer | ||
java::package: openjdk-17-jdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you say 11, but use 17? :)
includes: #1092