Bring start-slave script on MacOS inline with other OSes #780
Conversation
The start-slave script was not using the env vars properly This generates the start up options from the env vars in jenkins-slave
| java -jar <%= @slave_home %>/<%= @client_jar %> $JENKINS_SLAVE_ARGS | ||
| source <%= @defaults_location %>/jenkins-slave | ||
|
|
||
| # mandatory input vars |
There was a problem hiding this comment.
Instead of cut'n'pasting the the entire jenkins-slave-run script, how about installing it and call it from this script?
There was a problem hiding this comment.
Sounds like a good plan.
I think I did it this way because it wasn't an exact copy of the linux script.
I will see if I can reuse the linux script.
|
Dear @rendhalver, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Dear @rendhalver, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
1 similar comment
|
Dear @rendhalver, thanks for the PR! This is pccibot, your friendly Vox Pupuli GitHub Bot. I noticed that your pull request contains merge conflict. Can you please rebase? You can find my sourcecode at voxpupuli/vox-pupuli-tasks |
|
Closing for inactivity. |
The start-slave script was not using the env vars properly
This generates the start up options from the env vars in jenkins-slave
Fixes #779