Conversation
Instead of managing each setting with one augeas resource, only manage a single file resource with a template. Similarly when testing, instead of testing each setting in isolation, test the whole generated configuration file. Testing the augeas invocations gave no clue about the validity of the generated configuration file, and it greatly helps with performance as running the client configuration test suite took 1 minute 8.82 seconds to run 2248 examples, and now take less than 6 seconds to run 163 examples with a better coverage on my development manchine with: ``` bundle exec rspec spec/classes/openldap_client_config_spec.rb ```
Member
|
Presumably the configuration file was implemented like this for a reason? The module would not have removed any OS specific configuration that might have been included when openldap is installed. |
Member
|
(Originally using Shellvar in d87b145#diff-f8eb27ffa0a6bc6f80ed38e1d3697d52ee145f5b5ed07e87e256877a41e9602e in order to support RedHat by not messing with the RedHat managed config). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of managing each setting with one augeas resource, only manage a
single file resource with a template.
Similarly when testing, instead of testing each setting in isolation,
test the whole generated configuration file. Testing the augeas
invocations gave no clue about the validity of the generated
configuration file, and it greatly helps with performance as running the
client configuration test suite took 1 minute 8.82 seconds to run 2248
examples, and now take less than 6 seconds to run 163 examples with a
better coverage on my development manchine with: