Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Parameterization #34

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

[FIX] Parameterization #34

wants to merge 5 commits into from

Conversation

ryanhammonds
Copy link
Member

Allows y_array to be initialized in a parameterized WorkFlow, before it expected a bids repo or building y_array from .simulate calls.

The API needs to be simplified / re-written at some point. At the least, it could use stronger tests for a limited number of supported use case + profiling to fix bottlenecks and drop lines that are unused + better error/warning handling.

@codecov-commenter
Copy link

codecov-commenter commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 23.91304% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 65.72%. Comparing base (51ed7a8) to head (3556554).

❗ Current head 3556554 differs from pull request most recent head 4545b73. Consider uploading reports for the commit 4545b73 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
- Coverage   66.86%   65.72%   -1.15%     
==========================================
  Files           8        8              
  Lines         824      849      +25     
==========================================
+ Hits          551      558       +7     
- Misses        273      291      +18     
Files Coverage Δ
ndspflow/workflows/workflow.py 77.01% <55.00%> (-2.18%) ⬇️
ndspflow/workflows/param.py 12.16% <0.00%> (-0.52%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51ed7a8...4545b73. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants