Add support for building vsg and vsgXchange when system dep is not available #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psi29a
force-pushed
the
non_system_vsg
branch
2 times, most recently
from
37d9196
to
2aab173
Compare
|
Alright, looks like we got things building for vsg and vsgXchange, but master has a missing dither.glsl shader. |
psi29a
force-pushed
the
non_system_vsg
branch
from
2aab173
to
21d4fd6
Compare
…ipts*, add missing dither.glsl script
psi29a
force-pushed
the
non_system_vsg
branch
8 times, most recently
from
7322da3
to
2e57252
Compare
psi29a
force-pushed
the
non_system_vsg
branch
from
2e57252
to
0496e21
Compare
psi29a
force-pushed
the
non_system_vsg
branch
3 times, most recently
from
473509d
to
2dfc86f
Compare
psi29a
force-pushed
the
non_system_vsg
branch
from
2dfc86f
to
9b8ff91
Compare
psi29a
force-pushed
the
non_system_vsg
branch
from
2cbdd44
to
bfb24e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9
Not everyone has a system with VSG and VSGXCHANGE ready, so we specify which version and make sure the hash is correct to limit the security impact.
We can cache the results as well, so there is limited impact onbuild time as well.
We also now build without OSG, meaning that we no longer need OSG to build. We now will in all the necessary osg headers in
extern/osg; this is temporary until everything is moved over to using VSG. This means that there is some OSG cruft laying around but now we save time by not having to deal with OSG.We also enabled the launcher and some of the basic bits.
We we now build are:
Bonus points: found build bug in VSG:
vsg-dev/VulkanSceneGraph#1021
Note: flatpak still has issue with glslang support; tldr flatpak does not allow network access while building so vsg will fail to use git to clone their custom version. Will look into this later. The result of this issue is that vsgopenmw can't compile shaders and thus will fail to start. So the only usuable package is macos for now.