adding delayed removal of xobjectbucket #239
Conversation
wejdross
requested review from
a team,
Kidswiss,
TheBigLee and
zugao
and removed request for
a team
|
Did you test, that Crossplane correctly removes the |
| age := now.Sub(creationTimestamp.Time) | ||
|
|
||
| if age < 61*time.Minute { | ||
| return nil, fmt.Errorf("XObjectBucket is too young to be deleted") |
There was a problem hiding this comment.
NIT: Maybe print how many minutes remaining until it should be deleted.
There was a problem hiding this comment.
the phrasing "too young" really does not help. Either print the minutes as suggested above or just something like "XObjectBucket has been created less than 1 hour".
There was a problem hiding this comment.
I just added enhanced logging
I tested if xobjectbucket was gone after 61 seconds :D |
Could you still try it with a larger amount of time? 1 minute is within a single Crossplane reconcile loop. Also, something interesting to test as well: does it still delete it, if Crossplane gets restarted before the timer runs out? |
wejdross
force-pushed
the
xobjectbucket_delayed_removal
branch
from
b5d6a1f
to
3156fd9
Compare
|
Summary
Checklist
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog